Coding standards and best practices

Created on 30 January 2023, almost 2 years ago
Updated 8 December 2023, 11 months ago

The module has some coding standards and best practices issues.

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇮🇳India Raghavendra A M

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Raghavendra A M
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India Raghavendra A M

    Hi, Uploading patch for the fix.

  • 🇮🇳India roshni27

    Execute command : phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig facets_block

    FILE: /home/lenovo/d7to9/web/modules/contrib/facets_block/src/Plugin/Block/FacetsBlock.php
    ------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    ------------------------------------------------------------------------------------------
     123 | ERROR | [x] Use null coalesce operator instead of ternary operator.
     129 | ERROR | [x] Use null coalesce operator instead of ternary operator.
     136 | ERROR | [x] Use null coalesce operator instead of ternary operator.
     148 | ERROR | [x] Use null coalesce operator instead of ternary operator.
    ------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------
    
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    2 pass
  • 🇮🇳India roshni27

    PLEASE REVIEW THE PATCH.

  • Assigned to gnikolovski
  • 🇷🇸Serbia gnikolovski Subotica, Serbia
  • Status changed to Fixed 11 months ago
  • 🇷🇸Serbia gnikolovski Subotica, Serbia

    Fixed.

    Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024