off canvas region closes when clicking flag link

Created on 29 January 2023, over 1 year ago
Updated 14 May 2023, about 1 year ago

I added entity reference checkboxes and bookmark flag links to a views block in the off canvas region.
Sidr works as expected, but if I click on a checkbox or flag link, the region should not collapse.
Currently Sidr collapses the region on any click.

πŸ› Bug report
Status

Fixed

Version

4.0

Component

Code

Created by

πŸ‡³πŸ‡±Netherlands Yuri

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Yuri
  • πŸ‡³πŸ‡±Netherlands Yuri

    Maybe its better to *not* close the sidr off-canvas region when clicking a link at all.
    When a page is loaded using a link in the sidr off-canvas region, the whole page including the off canvas region is reloaded.
    See for example the off canvas menu of Olivero, that does not close itself when clicking a link.

  • πŸ‡³πŸ‡±Netherlands Yuri
  • πŸ‡³πŸ‡±Netherlands Yuri

    Also, any feature that expands or collapses a block in the sidr region, makes the sidr collapse, thus makes it disfunctional.

  • πŸ‡¨πŸ‡¦Canada jigarius MontrΓ©al

    Hey! Thanks for the info. I'll do my best to take a look at this at the earliest.

  • πŸ‡³πŸ‡±Netherlands Yuri

    I found a workaround, although its not optimal in user experience:

    .sidr.right:hover {
    right: 0;
    }

    This allows the sidr region to stay open when clicking inside sidr (unless the link requires a full page refresh), and sidr will close directly when hovering out of the sidr region.

    • 370749fe committed on 8.x-4.x
      Issue #3337373 by Yuri: Do not close Sidr when links therein are clicked
      
  • Status changed to Fixed about 1 year ago
  • πŸ‡¨πŸ‡¦Canada jigarius MontrΓ©al

    Done. Starting Sidr 4.x, clicking links inside Sidr won't close the Sidr panels. If someone wants to close Sidr panels in those events, they can simply attach an event listener and call Drupal.Sidr.closeSidr();.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024