- Issue created by @cburschka
- 🇨🇭Switzerland cburschka
This issue appears to have already existed in 9.4.8.
- 🇨🇭Switzerland cburschka
Correction, the issue has always existed when returning Filter::tips() as a string instead of Markup. This was introduced by #3207134: Add strict types to xbbcode → , which in a twist of dramatic irony does mention "methods which can return strings or MarkupInterface" as a potential obstacle, but fails to recognize that Filter::tips() is such a method.
Due to PHP silently casting the return value to string in methods that are hinted as string (instead of triggering a type error), this was not previously discovered.
- Status changed to Needs review
almost 2 years ago 11:40pm 28 January 2023 - @cburschka opened merge request.
-
cburschka →
committed 706289c4 on 5.0.x
Issue #3336436: Compose tips page doesn't render [font] or [color]...
-
cburschka →
committed 706289c4 on 5.0.x
- 🇨🇭Switzerland cburschka
This probably needs to be backported to 4.0.x, because the strict return types were in there as well.
-
cburschka →
committed 2f5f65d8 on 4.0.x
Issue #3336436: Compose tips page doesn't render [font] or [color]...
-
cburschka →
committed 2f5f65d8 on 4.0.x
- Status changed to Fixed
almost 2 years ago 11:54pm 28 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.