- Issue created by @rszrama
- Status changed to Fixed
about 2 years ago 7:30pm 26 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.
Currently, the add to cart subscriber that determines if a purchase is for a renewal has the following check:
$license_type_plugin = $variation->get('license_type')->first()->getTargetInstance();
if (!($license_type_plugin instanceof ExistingRightsFromConfigurationCheckingInterface)) {
return;
}
I think the intent of this was to see if the license is of a kind of type whose rights could be identified. In reality, the function that interface adds to the license type is not invoked during any part of this renewal flow - it's only used by the existing rights availability checker to prevent the accidental purchase of a duplicate license.
The problem this creates is with a license type like the one provided by Commerce File. It does not implement that interface, because the "rights" it grants are just to download any file attached to the related product variation.
A user may indeed have the right to download a file from one variation that exists on the variation they just added to the cart, but Commerce File also grants you perpetual access to download any updated or added file on the variation. Perhaps Commerce File should be updated to tie existing rights to the product variation then, but there may be reason to permit the purchase of the same file multiple times (i.e. based on download limit configurations).
I don't see any drawback of removing this interface check, but I guess we need to know why it was included in the first place. Will attach a patch and ping TomTech to weigh in after the testbot has had its fun.
Fixed
2.0
Code
Automatically closed - issue fixed for 2 weeks with no activity.