Port to Drupal 9 and 10

Created on 24 January 2023, almost 2 years ago

Problem/Motivation

As a site administrator running Drupal 9 or 10, I want to be able to add expiry dates for banned IP addresses, so they will be unbanned after a certain amount of time.

Proposed resolution

Port the module to Drupal 9 and 10.

Remaining tasks

  1. Fix module's automated testing (testbot) settings.
  2. Figure out what needs to be done and update this list.
  3. (port the module)
  4. Make a 2.0.0-beta1 release
  5. Test on PHP 7.3 and Drupal 9.4
  6. Make a 2.0.0-beta2 release
  7. Write automated tests for the new code.
  8. Make a full 2.0.0 release
  9. Add a README.
  10. Add a CHANGELOG.
  11. Make a 2.0.1 release.

User interface changes

Hopefully none.

API changes

Use a plugin manager instead of a hook.

Data model changes

I don't think there was a data model before; regardless; hopefully none.

πŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada mparker17 UTC-4

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mparker17
  • πŸ‡―πŸ‡΅Japan ilfelice

    Howdy,

    I tried to install 2.0.x-dev in a Drupal 9.5 test setup running on PHP 8.1, with the following results:

    Your requirements could not be resolved to an installable set of packages.
    
      Problem 1
        - drupal/blocked_ips_expire dev-2.0.x requires drupal/core ^10 -> found drupal/core[10.0.0, 10.0.1, 10.0.2, 10.0.3] but the        package is fixed to 9.5.3 (lock file version) by a partial update and that version does not match. Make sure you list it as an a       rgument for the update command.
        - drupal/blocked_ips_expire 2.0.x-dev is an alias of drupal/blocked_ips_expire dev-2.0.x and thus requires it to be installe       d too.
        - Root composer.json requires drupal/blocked_ips_expire 2.0.x-dev@dev -> satisfiable by drupal/blocked_ips_expire[2.0.x-dev        (alias of dev-2.0.x)].
    

    I can do more testing if necessary, so just let me know via reply.

  • πŸ‡¨πŸ‡¦Canada mparker17 UTC-4

    Hey @jorgemare!

    I started porting this from D7, but got distracted πŸ™ƒ

    The 2.0.x branch exists, but it doesn't really have any functionality in it right now - so even if you could install it, there's nothing to test right now, I'm afraid.

    You couldn't install it because when I port a module, I start by porting it to the latest stable version of Drupal (i.e.: in this case, Drupal 10) - and then - only after I have the majority of the functionality, and most importantly tests - I reduce the version requirements back to the last supported version of Drupal that I can set up automated tests for (i.e.: Drupal 9.4 or 9.5).

    I'm not exactly certain when I'll have time to work on this next, but it's on my TODO list for sure, and I'll update this ticket when I have news!

    Thanks for your understanding and patience!

  • πŸ‡―πŸ‡΅Japan ilfelice

    Hi @mparker!

    Thank you so much for the detailed explanation. I totally understand!

    If/when at some point you make progress and need testing, here I am to give a hand. ;)

  • πŸ‡ΊπŸ‡ΈUnited States douggreen Winchester, VA

    An alternative solution to this module for Drupal 9 is https://www.drupal.org/project/auto_unban β†’

  • πŸ‡¨πŸ‡¦Canada mparker17 UTC-4

    Updated version numbers in issue title.

    No progress to report, unfortunately: too many other things on my plate.

    The Auto UnBan module β†’ looks promising though: I'll take a closer look; thanks @douggreen!

Production build 0.71.5 2024