Update some documentation and code features

taraskorpach → closed merge request !2

Hi @jitesh_1
After reviewing the changes with @taraskorpach it looks good to me. Feel free to merge if you don't see any issues.

To be on the same page. I think there are some more issues in the code that needs to be fixed, like passing loaded entities into the queue. I will create issues for them later and should fix them the next week. After that, we need to make a new release. Hopefully working release, unlike the current one.

Hello @ReINFaTe,
Yes, we can produce a new release in the next week.
As I work on the other issue that should be resolved in the upcoming release

Hi, @jitesh_1. Can I ask you about the issue you are currently working on? I have some free time and I want to rewrite the queue logic, but I'm afraid our changes will conflict in the future.

I also hope that @ReINFaTe will create the issue he was talking about.

It would be very nice if you could let me know about it, thanks in advance.

Hi @taraskorpach
Thank you for your attribution. I reviewed the code of the module and I think the only issues preventing us from the release are
https://www.drupal.org/project/commerce_stock_notifications/issues/3337086 🐛 Fix passed items to the queue Needs review
https://www.drupal.org/project/commerce_stock_notifications/issues/3333086 🐛 Field "Sent on" is always empty Fixed

After that is fixed we can think about rewriting existing parts before the major release.
Not sure what issue @jitesh_1 is working on and I'm also curious to know what it is.

Hello @ReINFaTe and @taraskorpach,
I'm working on this issue https://www.drupal.org/project/commerce_stock_notifications/issues/3215770 ✨ anonymous cannot create notifications although /permissions allow it? Active
https://www.drupal.org/project/commerce_stock_notifications/issues/3223407 ✨ Proposed new features patch - allow anonymous, unsubscribe if duplicate Closed: duplicate
as this feature is need to important for our Commit.

Hi @jitesh_1
I think we shouldn't add new features right now.
First of all, we need to fix the most obvious bugs.
After that, I'd like to not use form_alter for injecting the subscription form into the cart. This approach isn't playing well with the possible custom add-to-cart forms (I experienced that on my own project). It'd be a very big change for our small module. And it can be a problem for anonymous users. Allowing anonymous to subscribe will most likely lead to the need for someone who uses our module to add a captcha to it at least. And we need to do our best so they can do it easily, Handling it for current form alter and future implementation seems like a waste.

Let me know what you think about that.

Hello @ReINFaTe,
I appreciate your response and have decided to postpone that issue until after the bugs have been released.

Automatically closed - issue fixed for 2 weeks with no activity.