Put payment status "failed" as a constant instead of "hard-coded" 2

Created on 22 January 2023, over 1 year ago

Problem/Motivation

Inside of PayinPayout class there is a logic to payment status failed. In the code is verifying by payment status === '2' and we don't know about what value is "2" until verify the documentation at https://github.com/payin-payout/payin-api

Proposed resolution

TO be easier to read the code we can define a constant like const PAYMENT_STATUS_FAILED = '2';

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Needs review

Version

1.0

Component

Code

Created by

🇧🇷Brazil RenatoG Campinas

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @RenatoG
@renatog opened merge request.
Comment over 1 year ago →
🇧🇷Brazil RenatoG Campinas
Done, created the merge request for that. Was defined a constant with the value, and put a comment in the code that will make easier to understand

The MR is ready to be mergeable: https://git.drupalcode.org/project/commerce_payin_payout/-/merge_requests/5

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024