- Issue created by @sergei_brill
- @sergei_brill opened merge request.
- Status changed to Needs review
about 2 years ago 8:03pm 21 January 2023 - Status changed to Needs work
almost 2 years ago 8:58am 23 January 2023 - 🇮🇱Israel jsacksick
@sergei_brill: Kinda tricky to modify the constructor arguments like this, but well, that should only be a problem for people extending the list builder.
Instead of having a
$productVariationTypeStorage
, let's just inject/use the entity type manager in case we need to get a different storage later too. -
jsacksick →
committed c3346eb3 on 8.x-2.x authored by
sergei_brill →
Issue #3335429 by sergei_brill, jsacksick: Product variation collection...
-
jsacksick →
committed c3346eb3 on 8.x-2.x authored by
sergei_brill →
- Status changed to Fixed
almost 2 years ago 12:38pm 23 January 2023 -
jsacksick →
committed 3efe374d on 3.0.x authored by
sergei_brill →
Issue #3335429 by sergei_brill, jsacksick: Product variation collection...
-
jsacksick →
committed 3efe374d on 3.0.x authored by
sergei_brill →
- @sergei_brill opened merge request.
- 🇷🇺Russia sergei_brill
@jsacksick Good note about the backward compatibility. But you made release with this issue so fast so, I couldn't fix it in time :)
Just in case you want to keep \Drupal\commerce_product\ProductVariationListBuilder compatible with previous versions of commerce 2, there is one more MR.
PS Commit it to 8.x-2.x only, 3.0.x may have BC breaks, I think. Automatically closed - issue fixed for 2 weeks with no activity.