Unnecessary workflow plugin manager cache tag

Created on 20 January 2023, over 1 year ago

Problem/Motivation

Discovered by Berdir in πŸ› ChainedFastBackend invalidates all items when cache tags are invalidated Fixed .

You only need cache tags for plugins if there are multiple variations (e.g. by theme) that can't be programmatically cleared one by one.

::clearCachedDefinitions() is the API for clearing plugin manager caches, and that either directly clears the item or uses the tags if defined.

Workflow module adds a cache tag for its plugin manager, but it's not needed for the plugins themselves, it's used in WorkflowAccessControlHandler to ensure the access changes when the plugin definitions update, which according to the docs is 'until extensions change'.

Installing modules clears all caches, so this should be completely unnecessary.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Fixed

Version

10.1 ✨

Component
WorkflowsΒ  β†’

Last updated 2 months ago

  • Maintained by
  • πŸ‡¦πŸ‡ΊAustralia @Sam152
Created by

πŸ‡¬πŸ‡§United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to RTBC over 1 year ago
  • Status changed to Fixed over 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024