- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 1:30pm 20 January 2023 - Assigned to Jay Jangid
- 🇮🇳India Jay Jangid
Thanks @irfan.gul for creating patch,still some issues find after applied the patch.
Now i am working on it.
- @jay-jangid opened merge request.
- Issue was unassigned.
- 🇮🇳India Jay Jangid
Created MR and solve all errors & warnings.
Please review.Thank you.
- 🇨🇦Canada Nathan Tsai
Thank you so much for these patches and so sorry for the delay.
Will aim to get this reviewed by next week.
- 🇮🇳India nayana_mvr
Verified MR!8. Except the following warning, all other errors are fixed:
FILE: /contrib/send_emails/src/EmailApi.php ----------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 158 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------------------------- Time: 368ms; Memory: 14MB
-
Jay Jangid →
committed 143aacb2 on 2.x
Issue #3335085: Phpcs coding standard drupal issues
-
Jay Jangid →
committed 143aacb2 on 2.x
-
Nathan Tsai →
committed 90034a48 on 2.x authored by
irfan.gul →
Issue #3335085 by Jay Jangid, irfan.gul, nayana_mvr: Phpcs coding...
-
Nathan Tsai →
committed 90034a48 on 2.x authored by
irfan.gul →
- Status changed to Fixed
over 1 year ago 6:12pm 6 May 2023 -
Nathan Tsai →
committed 90034a48 on master authored by
irfan.gul →
Issue #3335085 by Jay Jangid, irfan.gul, nayana_mvr: Phpcs coding...
-
Nathan Tsai →
committed 90034a48 on master authored by
irfan.gul →
-
Jay Jangid →
committed 143aacb2 on master
Issue #3335085: Phpcs coding standard drupal issues
-
Jay Jangid →
committed 143aacb2 on master
Automatically closed - issue fixed for 2 weeks with no activity.