"Shipment items" always show all items even that item is shipped

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
abx
I just have time to test this problem again and found that in "ShipmentForm.php", this line:

in_array($order_item->id(), $already_on_shipment, TRUE)) {

cause the problem in this issue. I can either remove "TRUE" or convert a value to be the same type. I decided to convert it. So, the code will change to

in_array(intval($order_item->id()), $already_on_shipment, TRUE)) {

Tested and work but since I don't know how to program, patch, etc. So, I hope, I did this correctly.

Thanks,
Status changed to Needs review over 1 year ago12:04pm 9 June 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update over 1 year ago
149 pass
@abx opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 1 year ago
140 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
last update about 1 year ago
149 pass

Comments & Activities