entity query (store) doesn't specify accessCheck() in PriceListForm leading to wsod

Created on 19 January 2023, almost 2 years ago
Updated 23 January 2023, almost 2 years ago

Problem/Motivation

The store query doesn't explicit call accessCheck() in the price list form. This gives a nice exception, as this is mandatory for Drupal 10.

Steps to reproduce

Install commerce + commerce price list. Try to add a new price list.

Proposed resolution

Add the accessCheck(). As we are not exposing any data here, I guess we can safely set the accessCheck to false.

Remaining tasks

Merge request.

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇩🇪Germany olafkarsten

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue was unassigned.
  • Status changed to Fixed almost 2 years ago
  • 🇦🇺Australia Andrew.Macpherson

    Thanks, everyone, for your work on this fix!
    I think I ran into this problem just now after going to use price lists.

    But (please forgive my ignorance), what's the next step?
    When and how will this be moved to a formal release?

    Thanks, Andrew

  • 🇮🇱Israel jsacksick

    If you really needed this patch, you could have applied it to your project. But I did tag a new release just now.

  • 🇦🇺Australia Andrew.Macpherson

    Thanks so much; I've updated and things are working just fine now!
    Apologies for not being quite tech-savvy enough to handle patches and stuff.
    I'll find out how to do that kind of thing …
    Cheers, Andrew

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024