Contrib.social

Organize example SVGs used for testing

Open on Drupal.org →
Created on 18 January 2023, almost 2 years ago
Updated 20 February 2023, almost 2 years ago

Problem/Motivation

As a follow-up to 🐛 SVG Image Field: FileValidationTest.php:85 fails on invalid_svg1.svg Fixed , we should clean up our SVG images used in the Unit and Functional tests.

it is more useful if the SVG files have more descriptive names instead of numbering them. I see the two remaining invalid SVG files have a script tag. One of them only has a script tag, so perhaps:

  • invalid_svg--svg-with-script-tag.svg
  • invalid_svg--script-tag-only.svg

And the valid ones:

  • valid_svg--with-xml-doctype.svg
  • valid_svg--no-doctype.svg

While we're at it, I would also place them in tests/resources instead of tests/src/Unit/test_data as in 🐛 Add inline SVG support for stage_file_proxy Fixed one of the SVG files is being used in a functional test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.2

Component

Code

Created by

🇪🇨Ecuador jwilson3

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024