Wrong LokiHandler class in README

Created on 18 January 2023, over 2 years ago

The README shows a sample service.yml configuration with the Itspire LokiHandler instead of the Drupal LokiHandler.

See https://git.drupalcode.org/project/monolog_loki/-/blob/1bde9d8df1489dcc1...

Should be like:


[...]
  monolog.handler.loki:
    class: Drupal\monolog_loki\Logger\Handler\LokiHandler
    arguments:
      - '@monolog_loki.util.settings'
      - entrypoint: 'http://localhost:3100'
[...]

🐛 Bug report
Status

Active

Version

1.0

Component

Documentation

Created by

🇦🇹Austria guedressel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇧🇪Belgium borisson_ Mechelen, 🇧🇪

    You are right that is confusing to first time users of this module that we do the dynamic swapping of the service, I don't know the reasons for doing it this way, we could look into changing this, but it would lead to a significant BC break, so it would have to be done in a new major release of this module.
    I'm not sure if this is worth it.

Production build 0.71.5 2024