Incorrect arguments to password.php10 service

Created on 17 January 2023, almost 2 years ago

Updated 23 May 2023, over 1 year ago

Problem/Motivation

The password.php10 service is currently given the same arguments as the olderpassword.php service, even though the constructor parameters are different.

Steps to reproduce

Change the password service to use password.php10, and update a user's password. The password_hash() function will fail because it's not given a correct algorithm.

Proposed resolution

Options:

Provide static algorithm and options values to the service
Provide an empty set of arguments so that the defaults are used (unless overridden).

Remaining tasks

User interface changes

API changes

Possibly deprecate the password_hash_cost service parameter.

Data model changes

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇨🇦Canada gapple

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Needs review almost 2 years ago9:37pm 17 January 2023
Comment over 1 year ago →
System Message

neclimdul → committed 776cf9ab on 2.0.x authored by gapple →
Issue #3334314: Incorrect arguments to password.php10 service
Status changed to Fixed over 1 year ago4:50pm 23 May 2023
Comment over 1 year ago →
🇺🇸United States neclimdul Houston, TX
Good catch, thanks! Looks like this wasn't a real "problem" I'd noticed since it wasn't used yet. Not sure how i didn't catch it when developing it but...
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024