Check that 'replicate' link template exists before trying to use it

Created on 17 January 2023, over 1 year ago

Updated 24 March 2023, over 1 year ago

Problem/Motivation

Periodically our site will start throwing exceptions like

Drupal\Core\Entity\Exception\UndefinedLinkTemplateException: No link template 'replicate' found for the 'node' entity type in Drupal\Core\Entity\EntityBase->toUrl() (line 196 of /mnt/www/html/docroot/core/lib/Drupal/Core/Entity/EntityBase.php

Even though nodes are definitely configured to use replicate. This is temporarily fixed with a cache rebuild but it always pops up again.

Looking around there is a similar issue from paragraphs https://www.drupal.org/project/paragraphs/issues/3238515#comment-14272727 💬 No link template 'canonical' found for the 'paragraph' entity type Fixed that points to a usage of toUrl() without first calling hasLinkTemplate() and looking at replicate_ui there is indeed a usage of toUrl() without first checking the link template exists

https://git.drupalcode.org/project/replicate_ui/-/blob/8.x-1.x/replicate...

  if ($supports_replicate) {
    $url = $entity->toUrl('replicate');

    if ($url->access()) {

Proposed resolution

Add hasLinkTemplate('replicate') check before trying to use toUrl('replicate')

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States ctrlADel North Carolina, USA

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Needs review over 1 year ago4:13am 17 January 2023
First commit to issue fork.
Comment over 1 year ago →
System Message

Berdir → committed 59e19db8 on 8.x-1.x authored by ctrlADel →
Issue #3333999 by ctrlADel: Check that 'replicate' link template exists...
Status changed to Fixed over 1 year ago11:57pm 24 March 2023
Comment over 1 year ago →
🇨🇭Switzerland Berdir Switzerland
Thanks, merged. As also mentioned in 🐛 Error url operations Closed: duplicate , seems weird that this happens, especially as a cache clear fixes it. This likely points to a bigger issue on sites where this happens, see 🐛 ModuleHandler skips all hook implementations when invoked before the module files have been loaded Needs work

But it doesn't hurt to be more defensive here.
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024