- First commit to issue fork.
- Merge request !22Issue #3333745: Trusted browser message when set to 1 day is "1 days" plural → (Closed) created by technoveltyco
- Status changed to Needs review
almost 2 years ago 3:40pm 27 January 2023 - 🇬🇧United Kingdom technoveltyco
Hi everyone,
I created the patch 3333745-5-2.0.0@alpha.patch → to solve that fixes the singular/plural day(s) wording in the module.
There is also an open merge request you can review.
Message when Cookie expiration is 1 day
Message when Cookie expiration is x days
- 🇬🇧United Kingdom dunx
This is now working as expected on the site we're using it on. Happy for it to be mark as closed.
- Status changed to RTBC
over 1 year ago 1:29pm 25 February 2023 - Status changed to Needs work
over 1 year ago 5:05pm 27 February 2023 - 🇵🇹Portugal jcnventura
This is adding a couple of \Drupal::translation() calls that should be avoided. It is very likely that the StringTranslationTrait already adds this service to the plugin anyway.
-
jcnventura →
authored b336ee68 on 2.x
Issue #3333745 by technoveltyco, dunx, jcnventura: Trusted browser...
-
jcnventura →
authored b336ee68 on 2.x
- Status changed to Fixed
over 1 year ago 5:10pm 27 February 2023 - 🇵🇹Portugal jcnventura
Yep, the service was already there, so a simple $this->formatPlural can be used.
Automatically closed - issue fixed for 2 weeks with no activity.