- Merge request !69Issue #3333510: `IndexedItemsEvent` represents processed (all) items as successfully indexed, when some may be rejected → (Open) created by bradjones1
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for suggesting this change!
You’re right, including this information in the event makes sense. This is neither a bug nor major, though – it’s a request for a new feature, and the “bug” part is a single wrong word in a doc comment, so definitely not major.Also, as stated in the information when creating an issue, please do not use merge requests in this module’s issue queue as testing doesn’t work for them. (See #3190024: Problem with test dependencies when testing issue forks → for details.)
Anyways, please see my suggested additions/changes in the attached patch.
I also create a change record → – sorry, I didn’t see yours in time, otherwise I would have just edited it. (Not sure what to do now. Probably I will have to ask d.o maintainers to delete the unused one.)
Please give my patch a look and a try, and see if it works for you. The last submitted patch, 4: 3333510-4--additional_info_items_indexed_event.patch, failed testing. View results →
- 🇦🇹Austria drunken monkey Vienna, Austria
Huh, I can’t reproduce that test failure, at least with D10. Let’s see if test bot also fails for D10.
- 🇦🇹Austria drunken monkey Vienna, Austria
Any feedback on this?
It of course wouldn’t make much sense to add this new functionality if no-one is going to use it. - 🇺🇸United States bradjones1 Digital Nomad Life
Sorry I haven't had a chance to loop around on this but I will soon. Appreciate your eyes on this.
- 🇺🇸United States bradjones1 Digital Nomad Life
Tests are green on the MR. As for the duplicate CRs I think we can just leave one in draft.