routeHasModal return value breaks form alter check

Created on 13 January 2023, almost 2 years ago
Updated 18 January 2023, almost 2 years ago

Problem/Motivation

The change of the return value of routeHasModal in #3324803: Add optional parameters for indiviual routes breaks the check in route_in_modal_form_alter(), causing all routes without parameters in the module config to be regarded as route without modal.

Proposed resolution

Fix for now would be to check if the return value of routeHasModal equals FALSE.

Better would be to also revert the return value of routeHasModal() to boolean only, and provide new function to get the route parameters.
This is something for a separate issues though.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇧🇪Belgium andreasderijcke Antwerpen / Gent

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024