Created on 13 January 2023, almost 2 years ago
Updated 27 January 2023, almost 2 years ago

Since early October, some test configurations have been consistently failing on the testbot because PHPCS has been aborting with no output and no error message. This is what it looks like in the console log:

00:52:26 Executing PHPCS.
00:52:26 cd modules/contrib/entity && sudo -u www-data /var/www/html/vendor/bin/phpcs --report-full=/var/lib/drupalci/workdir/phpcs/codesniffer_results.txt --report-checkstyle=/var/lib/drupalci/workdir/phpcs/checkstyle.xml --report-diff=/var/lib/drupalci/workdir/phpcs/codesniffer_fixes.patch --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md /var/www/html/modules/contrib/entity
02:40:11 Build timed out (after 110 minutes). Marking the build as aborted.

(See the test output at https://www.drupal.org/node/626176/qa β†’ )

As you can see, the build times out and aborts, leaving no feedback as to why.

After communicating with @hestenet on Slack (See https://drupal.slack.com/archives/C51GNJG91/p1670445600598589) he determined it was the same problem seen here: https://www.drupal.org/project/drupalci_testbot/issues/3283978#comment-1... β†’

Specifically, if you use @code in a documentation comment without a corresponding @endcode, PHPCS will fail.

I checked the Entity API codebase and indeed we have exactly one place where we use @code/@code mistakenly instead of @code/@endcode. Here is a patch to see if changing this will fix things with the Entity API tests.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code - misc

Created by

πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024