PHP 8.1 deprecation explode(): Passing null to parameter #2

Created on 12 January 2023, over 1 year ago

Updated 12 January 2024, 6 months ago

Problem/Motivation

In a Drupal 9.5.0 with Advanced Varnish 4.0.7 running on the PHP 8.1, we are seeing this deprecation message:

Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated in Drupal\adv_varnish\CacheManager->getCacheSettings() (line 446 of /my_drupal_path/web/modules/contrib/adv_varnish/src/CacheManager.php)

Steps to reproduce

The error seems to be triggered when users are authenticating to Drupal and cache control header is not set I believe.
I am not able to reproduce this in my local, but seen these errors in production.

Proposed resolution

Implemented logic to check if parameter #2 is not empty before calling explode() function.
Patch is attached below.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States mihaic

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!15PHP 8.1 deprecation explode(): Passing null to parameter #2
Merged
🇵🇱Poland shumer
updated 6 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
Merge request !15Issue #3333068 by mihaic: PHP 8.1 deprecation explode(): Passing null to parameter #2 → (Merged) created by shumer

Comment 6 months ago →

System Message

shumer → committed 23184851 on 4.x

Issue #3333068 by mihaic: PHP 8.1 deprecation explode(): Passing null to...

Status changed to Fixed 6 months ago1:26pm 29 December 2023
Comment 6 months ago →
🇵🇱Poland shumer Wroclaw
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024