Rename post_update_add_hierarchy_processor

Created on 11 January 2023, almost 2 years ago
Updated 26 June 2024, 5 months ago

Problem/Motivation

facets_post_update_8001_8001_8001_8001_8001_8001_8001_8001_add_hierarchy_processor's name is too repetitive

Steps to reproduce

In file facets.post_update.php line 11
facets_post_update_8001_8001_8001_8001_8001_8001_8001_8001_add_hierarchy_processor

Proposed resolution

Rename hook to facets_post_update_add_hierarchy_processor

Feature request
Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇫🇷France rbrissaud

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update over 1 year ago
    424 pass, 2 fail
  • 🇮🇳India Ameer Khan

    The post-update was not executed after updating the module to 2.0.6. So we changed the hook name from facets_post_update_8001_8001_8001_8001_8001_8001_8001_8001_add_hierarchy_processor to facets_post_update_8001_add_hierarchy_processor as in 3.x https://git.drupalcode.org/project/facets/-/blob/3.0.x/facets.post_updat... & fixed the issue.

  • 🇺🇸United States amanire

    Patch in #4 worked for me. Sure would be nice to get this into an official release.

    facets 8001_add_hierarchy_process post-update Add the hierarchy processor to facets that have the hierarchy

  • Status changed to RTBC about 1 year ago
  • 🇺🇸United States amanire

    Restating since I updated the previous comment. #2 works for me and follows Drupal documentation for hook_post_update_NAME.

  • Status changed to Closed: won't fix 5 months ago
  • 🇧🇪Belgium borisson_ Mechelen, 🇧🇪

    I think this is a good idea if we would've seen this closer to when this was added, since it has been a while now, I think it will only lead to trouble and it just a cosmetic fix. I think therefor we should just won't fix this issue.

Production build 0.71.5 2024