Drupal 10 update

Created on 11 January 2023, almost 2 years ago
Updated 9 May 2024, 8 months ago

Problem/Motivation

More projects will be moved to Drupal 10 moving forward so it would be good if the module could be updated accordingly.

Steps to reproduce

Check the module status using upgrade-status - this shows that the module is not compatible with Drupal 10 yet.

Proposed resolution

Update the module code and yml files to support Drupal 10.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇱Netherlands roaldnel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Would be good to get this merged into the module.

  • 🇳🇱Netherlands roaldnel

    @jsacksick It seems like the code was committed but it does not get pulled through via composer. Can you possibly create a new release for the module with the updated code for the community to use? Thanks in advance!

  • 🇮🇱Israel jsacksick

    There's no release... and no active work being done on this module...

  • 🇺🇸United States hockey2112

    Is this patch all that is needed to make this module Drupal 10 compatible? When I examine the module using the upgrade_status module, it returns several issues/reasons for not being D10 compatible.

    File name Line Error
    C:\xampp\htdocs\mysite\public_html\modules\custom\commerce_fee\commerce_fee.post_update.php 15 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

    C:\xampp\htdocs\mysite\public_html\modules\custom\commerce_fee\commerce_fee.post_update.php 26 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

    C:\xampp\htdocs\mysite\public_html\modules\custom\commerce_fee\src\FeeListBuilder.php 21 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

    C:\xampp\htdocs\mysite\public_html\modules\custom\commerce_fee\src\FeeStorage.php 49 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

    C:\xampp\htdocs\mysite\public_html\modules\custom\commerce_fee\src\Form\FeeForm.php 23 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

  • 🇺🇸United States hockey2112

    Checking in about this item, as it is blocking me from upgrading from Drupal 9 to Drupal 10.

  • 🇺🇸United States hockey2112

    Ignore my previous. I apparently had the "custom" version of this module from back when it was first created and provided in a core forum thread. To fix my issue, I did the following:

    1. Back up my existing fees data
    2. Uninstall the custom fee module (which required me to delete all fees)
    3. Manually installed the contrib fee module, with the patch listed here.
    4. Recreate my fees
    5. Remove the outdated fee code from the Commerce PluginItemDeriver file
  • 🇺🇦Ukraine khiminrm

    Fixed warnings from the upgrade_status

Production build 0.71.5 2024