Contrib.social

On clean install, crop does not work. Fatal error do to missing entity type.

Open on Drupal.org →
Created on 10 January 2023, almost 2 years ago
Updated 27 January 2023, almost 2 years ago

Error on clean install.

Visiting the edit page for any media results in this fatal error. Also, crop functionality in image styles does not work. The result is the generated Widen urls will only add height+width but nothing crop related. This is important because we can't make good use of image styles without it.

I tried on a clean install of 9.4 and 9.5. Same result.

The website encountered an unexpected error. Please try again later.

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "crop" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of core/lib/Drupal/Core/Entity/EntityTypeManager.php).
Drupal\Core\Entity\EntityTypeManager->getHandler('crop', 'storage') (Line: 192)
Drupal\Core\Entity\EntityTypeManager->getStorage('crop') (Line: 183)
Drupal\acquia_dam\ImageStyleHelper->getCrops(Object) (Line: 74)
Drupal\acquia_dam\Form\FocalPointMediaEditFormAlter->formAlter(Array, Object) (Line: 400)
acquia_dam_form_media_form_alter(Array, Object, 'media_acquia_dam_image_asset_edit_form') (Line: 562)
Drupal\Core\Extension\ModuleHandler->alter('form', Array, Object, 'media_acquia_dam_image_asset_edit_form') (Line: 838)
Drupal\Core\Form\FormBuilder->prepareForm('media_acquia_dam_image_asset_edit_form', Array, Object) (Line: 282)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 707)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Install Acquia DAM. Visit any edit page for media.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States davidhernandez USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    oof! Sorry about that, working on a fix and a patch release.

  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA
  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    Here's a patch to get started. This should have been caught by tests, but this means we have no test coverage of the media edit form.

  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    Oops wrong patch.

  • Comment almost 2 years ago →
    🇺🇸United States davidhernandez USA

    @mglaman Thanks. I'll test this. Do you think this will resolve any issues with the link generation? That also seems to have an issue. The links generated are not using any crop functions from the image styles.

  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    Do you think this will resolve any issues with the link generation

    Do you mean integration links inside of the DAM? Which issues are you experiencing (sounds like it's worth a new issue.)

    The links generated are not using any crop functions from the image styles.

    Again, depends what we mean by links here. Feel free to also ping me in Drupal Slack

  • Comment almost 2 years ago →
    🇺🇸United States davidhernandez USA

    @mglaman I was partly mistaken. It looks like crop works and resize works, but the scale and crop image effect doesn't work. Is that supposed to be supported? I'm using basic image styles, view modes, in Drupal on an image field to display the image. So the urls generated in Drupal to retrieve the Widen asset.

    Example:
    <img src="https://abcdef.widen.net/content/484d0b1f-df73-4a3d-9ac4-88d7a65e5303/web/image.png?h=200&amp;crop=yes&amp;k=c&amp;w=200&amp;itok=K6aVmGmT" width="200" height="200" alt="CHIRP_wide.png" loading="lazy">

    I'm playing with this field trying different things. It seems rotate works as long as it is 90deg, and I think desaturate worked, but I didn't realize it was specifically the scale and crop I was having issue with.

    I can open a separate issue if this sounds broken.

  • Comment almost 2 years ago →
    🇺🇸United States davidhernandez USA

    Following up specifically about the form error. This patch resolves it. I'm seeing some other errors in the log that may be other issues. I'll try to verify and open other issues.

  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    @davidhernandez can you make another issue? We should have fixed this. Can you try on -dev as well (if you haven't) as I think it was fixed with https://git.drupalcode.org/project/acquia_dam/-/commit/fbf1ee7a0c5ad8ff8....

    I'll be making a patch release for this issue which will also release that fix.

  • Comment almost 2 years ago →
    🇺🇸United States davidhernandez USA

    I'm using composer and this should be the latest dev release. It matches the commit id. I'll make a new issue.

          "name": "drupal/acquia_dam",
            "version": "dev-1.0.x",
            "source": {
                "type": "git",
                "url": "https://git.drupalcode.org/project/acquia_dam.git",
                "reference": "edca371760b6f7ed146bfee8e76a3e13aefb9fb2"
  • Issue was unassigned.
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    Thanks! That sounds like a different bug. A lot of the scaling image style was worked on, but really needs end-user testing to cover edge cases.

    This was fixed in https://git.drupalcode.org/project/acquia_dam/-/commit/6f7e6622349ef5ec0..., preparing a new patch release.

  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA
  • Comment almost 2 years ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024