- @mxh opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:19am 28 January 2023 - 🇩🇪Germany mxh Offenburg
The underlying problem here is, that a nested update of the same entity is happening, since the model reacts upon the "Update content entity" event. I was wondering why the infinite recursion detection was not kicking in here, and it turns out that the entity system relies on values of the original object. On a nested update, the values of the attached original object can be out of date. For this case, I've added a refresh of the original object in the update action (see MR296).
To prevent the infinite recursion, you could work this a token that is being exposed as context. I've added this to your example model (see uploaded file attachment).
- Assigned to mxh
- Status changed to Needs work
almost 2 years ago 11:50am 28 January 2023 - 🇩🇪Germany mxh Offenburg
I think it makes sense to also add this to the generic save action. Will have a look.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:17pm 28 January 2023 - Status changed to RTBC
almost 2 years ago 12:57pm 28 January 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
OMG, I completely missed the recursion myself. So glad you caught this, and the resolution looks perfect.
-
jurgenhaas →
committed a5152726 on 1.2.x authored by
mxh →
Issue #3331810 by mxh, jurgenhaas: Plugin "Entity: set field value" not...
-
jurgenhaas →
committed a5152726 on 1.2.x authored by
mxh →
-
jurgenhaas →
committed 462e00f2 on 1.1.x authored by
mxh →
Issue #3331810 by mxh, jurgenhaas: Plugin "Entity: set field value" not...
-
jurgenhaas →
committed 462e00f2 on 1.1.x authored by
mxh →
- Status changed to Fixed
almost 2 years ago 1:04pm 28 January 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Merged into 1.2.x and back ported to 1.1.x - thanks @mxh for your help on this.
- Status changed to Needs work
almost 2 years ago 9:14am 29 January 2023 -
jurgenhaas →
committed d5855aeb on 1.0.x authored by
mxh →
Issue #3331810 by mxh, jurgenhaas: Plugin "Entity: set field value" not...
-
jurgenhaas →
committed d5855aeb on 1.0.x authored by
mxh →
- Status changed to Fixed
almost 2 years ago 9:48am 29 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.