- 🇪🇸Spain akalam
This is only failing when the field is configured to use select form elements, when using input html5 elements the copy feature works fine.
After looking closer, I think this commit might introduce the issue https://git.drupalcode.org/project/office_hours/-/commit/93ff3da18e18d40...There's a big refactor on the office_hours.js file on the dev release. I didn't test it, but it could be already fixed on the dev release. Can somebody test it there?
- 🇨🇦Canada ebremner
I can confirm that this is happening with HTML 5 time as well and with the 1.8 and dev versions. My suggestion is not to have the copy previous day for exceptions since it does not really make sense for this case. They will just add exceptions not use other days. Will try and create a patch to remove the link.
- 🇳🇱Netherlands johnv
I can imagine a use case where you want to enter a list exceptions, that are (almost) identical. The link would then copy the hours, leaving the date alone. YOu will maintain the dates separately.
- 🇨🇦Canada ebremner
Ok well the Copy link is not working at all for exception hours, can we remove it for now until that is fixed. I will provide a patch now to make this happen.
- Status changed to Fixed
over 1 year ago 2:15pm 12 May 2023 - 🇳🇱Netherlands johnv
Indeed, better no functionality the broken functionality.
The problem occurs both in Exception List widget as in basic list widget (to be toggled with the Widget)However, I decided to spend too much time fixing this. Having learned a lot about (debugging) javascript, though.
Thanks anyway. - 🇨🇦Canada ebremner
Hi John,
The Copy link is still not working for me in exception hours, it just sits there.Thanks,
Eric - Status changed to Needs work
over 1 year ago 7:47am 15 May 2023 - Status changed to Fixed
over 1 year ago 11:26am 15 May 2023 - 🇳🇱Netherlands johnv
I tested on Edge, Chrome, Firefox.
The only problem I encountered, is that the JS was not refreshed in Firefox.
You need to refresh the edit page using [CTRL+F5], not just [F5], to explicitely reload the JS.
Not sure why this is happening. Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 11:54am 31 May 2023 - 🇨🇦Canada ebremner
Yes it works as expected now with dev and a refreshed browser.