Fix PHPCS errors and warnings

FILE: /flexible_permissions/tests/src/Unit/ChainPermissionCalculatorTest.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AND 2 WARNINGS AFFECTING 17 LINES -------------------------------------------------------------------------------------------------------------------------------- 157 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 196 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 261 | ERROR | [ ] Description for the @return value is missing 304 | ERROR | [x] Missing class doc comment 306 | ERROR | [x] Missing function doc comment 311 | ERROR | [x] Missing function doc comment 317 | ERROR | [x] Missing class doc comment 319 | ERROR | [x] Missing function doc comment 324 | ERROR | [x] Missing function doc comment 330 | ERROR | [x] Missing class doc comment 334 | ERROR | [x] Missing class doc comment 336 | ERROR | [x] Missing function doc comment 342 | ERROR | [x] Missing class doc comment 344 | ERROR | [ ] Missing member variable doc comment 346 | ERROR | [x] Missing function doc comment 348 | ERROR | [x] Expected 1 blank line after function; 0 found 349 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /flexible_permissions/src/CalculatedPermissionsItem.php ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 52 | ERROR | Type hint "array" missing for $permissions ----------------------------------------------------------------------------------------------------------------- FILE: /flexible_permissions/src/ChainPermissionCalculatorInterface.php -------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------- 21 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------- FILE: /flexible_permissions/src/RefinableCalculatedPermissionsInterface.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------- 29 | ERROR | Missing parameter type 31 | ERROR | Missing parameter type ------------------------------------------------------------------------------------------------------------------------------- FILE: /flexible_permissions/src/CalculatedPermissionsTrait.php ------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 22 | ERROR | [x] Use null coalesce operator instead of ternary operator. ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update 12 months ago
Not currently mergeable.
Comment 12 months ago →
System Message

kristiaanvandeneynde → committed fc6a45e1 on 1.1.x
Issue #3331155 by SolimanHarkas, kristiaanvandeneynde: Fix PHPCS errors...
Status changed to Fixed 12 months ago12:26pm 11 October 2023
Comment 12 months ago →
🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
IIRC lines exceeding 80 characters is fine for the first line of a docblock, so ignoring that one. Fixed the stuff that was still relevant and will provide issue credit. Thanks!
Comment 12 months ago →
System Message
kristiaanvandeneynde → closed merge request !4
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix PHPCS errors and warnings

PHPCS reported the following errors and warnings:

Comments & Activities