Update Drupal core to 10.x in farmOS

Minor title change to make this issue easier to find among related issues. :-)

I'm also keeping my eye on some Drupal core issues that are progressing, and may change the way that we do things in farmOS.

For example this one: 🐛 Installing a module causes translations to be overwritten Fixed

Related to our previous issue that added a hard-coded override/workaround: #3257430: Do not allow the default language to be changed from English →

There are probably others... I'll link them in this thread so we remember to consider them.

A critical question we need to answer is: will we need to consider Drupal 10 a "breaking change" and therefore will we need to create a 3.x branch of farmOS for it?

Discussed this a bit in chat today with @farmer-ed and @paul121 and I think we concluded that we WILL indeed need to increment farmOS's major version to 3 when we merge this. Here is why:

I think we do, if only because it will then require any custom/contrib modules to update their composer.json files to farmos/farmos ^3.0 to indicate their compatibility with D10
Otherwise there's a risk that they aren't actually compatible with ^2.0 anymore
So just like Drupal needs to increase it's major version alongside Symfony major versions, I think we do as well

Full chat: https://irc.farmos.org/bot/log/farmOS/2023-03-07#T88341

Update: config_update, csv_serialization, and exif_orientation all have tagged releases that support D10 now.

I rebased, updated, and force-pushed my 2.x-d10 branch on GitHub: https://github.com/mstenta/farmOS/tree/2.x-d10

Note: we use the Classy theme in one of the farm_ui_views tests. Classy is removed from Drupal 10, so this will need to be refactored.

Note: we use the Classy theme in one of the farm_ui_views tests. Classy is removed from Drupal 10, so this will need to be refactored.

Addressed by https://github.com/farmOS/farmOS/pull/680

Update: jsonapi_schema → released 8.x-1.0-rc1 → with D10 compatibility! 🎉

Update: entity_reference_validators → released 8.x-1.0-beta2 → with D10 compatibility! 🎉

Thanks to @pcambra!

Update: I released Log 2.1.0 with Drupal 10 support.

Here are instructions for setting up a local development environment for testing my 3.x branch of farmOS:

# Clone my 3.x branch of the repo.
git clone --branch '3.x' git@github.com:mstenta/farmOS.git

# Build farmos/farmos:3.x and farmos/farmos:3.x-dev Docker images locally.
docker build --build-arg PROJECT_VERSION=3.x --build-arg FARMOS_REPO=https://github.com/mstenta/farmOS --build-arg FARMOS_VERSION=3.x -t farmos/farmos:3.x farmOS/docker
docker build --build-arg PROJECT_VERSION=3.x --build-arg FARMOS_REPO=https://github.com/mstenta/farmOS --build-arg FARMOS_VERSION=3.x -t farmos/farmos:3.x-dev farmOS/docker/dev

# Create local dev environment w/ running containers.
mkdir farmOS_3.x && cd farmOS_3.x
curl https://raw.githubusercontent.com/mstenta/farmOS/3.x/docker/docker-compose.development.yml -o docker-compose.yml
docker compose up

# Install via Drush.
docker exec -it -u www-data farmos_3x-www-1 vendor/bin/drush site-install -y --db-url=pgsql://farm:farm@db/farm --account-pass=admin

Current status: Things seem to be working well in the 3.x branch!

There are two issues that are preventing tests from passing in GitHub Actions:

1. paratest doesn't seem to be working - not sure why yet. Changing to use phpunit allows the tests to pass.
2. We use some code that has been deprecated in Drupal 11, and our phpunit.xml configuration only ignores "indirect" deprecations (via <env name="SYMFONY_DEPRECATIONS_HELPER" value="quiet[]=indirect"/>). Changing that to disabled allows tests to pass.

Both of those temporary fixes are demonstrated in my 3.x-wip branch currently, which is passing in GitHub Actions.

paratest doesn't seem to be working - not sure why yet. Changing to use phpunit allows the tests to pass.

I was wrong about this. Tests on MariaDB pass w/ paratest, when deprecation notices are ignored. They fail on PostgreSQL for some other reason... I'll investigate that separately...

I think the PostgreSQL + paratest failures are a side-effect of #3270558: Install and create the postgres pg_trgm extension in docker container → . So we've decided to go back to using phpunit directly, for the time being. Hopefully we can follow-up and figure out how to make them work in paratest again soon.

I think this is "complete" in the sense that all the necessary changes have been made and things seem to be working in local testing. Marking this as "Needs Review".

Merged PR: https://github.com/farmOS/farmOS/pull/742

Automatically closed - issue fixed for 2 weeks with no activity.