-
bnjmnm β
committed 8c8f8b24 on 10.1.x
Issue #3329863 by bronzehedwick, andy-blum, _utsavsharma: Improve...
-
bnjmnm β
committed 8c8f8b24 on 10.1.x
- Status changed to Fixed
over 1 year ago 7:33pm 17 February 2023 - πΊπΈUnited States bnjmnm Ann Arbor, MI
- I tried several modifications of this approach just to see if I liked it better or it saved LOC or overhead. Nothing I changed was an improvement, so I'm pleased with what has been provided.
- I ran some performance analysis tools comparing HEAD vs what is in the patch, and this is ~40% less demanding, so a really nice clear improvement. I tried a comparison replacing the use of translateY here with translate3d and there was not enough of a difference to suggest a switch would be benefifical. I ran a few profiles and if anything translate3d was a little more demanding, but even then it was by a microtrivial amount
Tthanks @andy-blum for hopping on a Zoom to walk me through this. This seemed pretty complex but a brief explanation revealed this to be a pretty straghtforward and thoughtful fix.
I'm going to run tests on 10.0.x just in case there are any build tool differences before backporting.
Automatically closed - issue fixed for 2 weeks with no activity.