Filter on module description (module_filter)

Created on 18 December 2022, over 1 year ago
Updated 10 February 2023, over 1 year ago

Problem/Motivation

In #3212569: Permissions filter appears to filter on module name, but doesn't make that clear β†’ the UI text placeholder was changed to make it clear that filtering is done on the module . It would also be good to filter on the description of the module (on the module page) and the text of the permission (on the permissions page)

Steps to reproduce

On the modules page, with just the filter provided by Core (module_filter NOT enabled)

  • Filter for 'db' shows the Database Logging module. Machine name is dblog. The text 'db' does not appear in the description, showing that filtering works on the machine name
  • Filter for 'internal' shows Internal Page Cache. Machine name is page_cache, and 'internal' is not in the description. This shows that the filtering is working on the displayed name
  • Filter on 'visit' shows the Ban module, which has machine name ban, but description contains the word 'visit'. So core filtering also uses the description

With module_filter enabled:

  • Filter for 'db' - same as core, filtering works on the machine name
  • Filter for 'internal' - same as core, filtering works on the displayed name
  • Filter on 'visit' - shows nothing. Filtering does NOT use the description

Proposed resolution

Add filtering on description, to replicate what the core does.

Remaining tasks

  1. Make modules install page filter on description
  2. Make modules uninstall page filter on description
  3. Add javascript test coverage for the filtering on both pages
πŸ“Œ Task
Status

Fixed

Version

4.0

Component

User interface

Created by

πŸ‡¬πŸ‡§United Kingdom jonathan1055

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024