Headers may not be properly processed

Created on 17 December 2022, about 2 years ago
Updated 30 July 2023, over 1 year ago

Problem/Motivation

  • Headers aren't being included in the request
  • The input box is a single line which doesn't allow me to submit multiple headers
  • Using '\r\n' may not work cross-platform

Steps to reproduce

  1. Add a rule for Request HTTP data
  2. See that you can't add more than one line in the Headers input box
  3. Add a header
  4. Make a request
  5. The header isn't added

Proposed resolution

  • Change the input box for Headers to be multi-line
  • Check if the $headers is already an array before exploding
  • Change the explode to use only '\n' and then trim the values to remove any '\r' characters

Remaining tasks

  • Submit a patch

User interface changes

  • Headers input box is changed to multi-line input

API changes

  • n/a

Data model changes

  • n/a
🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States josephcmiller2

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024