- Merge request !147Draft: Issue #3327584: New contribution records system → (Closed) created by fjgarlin
- 🇪🇸Spain fjgarlin
Update: functionality-wise, everything is there. We're starting to review/improve and see if there is anything missing.
The D7 changes can be seen in the MR for this issue. The whole plan (D7 + D9 new system) is in the google doc linked in the issue description.
- 🇪🇸Spain fjgarlin
fjgarlin → changed the visibility of the branch 7.x-3.x to hidden.
- Status changed to Needs work
11 months ago 9:46am 24 July 2024 - 🇪🇸Spain fjgarlin
The new MR contains the code from the old one as it was 2 years behind and rebase didn't work straightaway.
I will need to deploy this again to a D7 site and test.
- 🇪🇸Spain fjgarlin
fjgarlin → changed the visibility of the branch 3327584-contribution-records-new-system to hidden.
- 🇪🇸Spain fjgarlin
With such a complex MR, it was easier to redo the whole thing than rebasing. New MR: https://git.drupalcode.org/project/drupalorg/-/merge_requests/332
- 🇪🇸Spain fjgarlin
I will try to split the MR into two:
- One for pushing data to D10
- One for reading that data from D10 - Merge request !336Resolve #3327584 "Receive contrib records from d10" → (Closed) created by fjgarlin
- 🇪🇸Spain fjgarlin
First part: Send data to new.drupal.org:
- MR: https://git.drupalcode.org/project/drupalorg/-/merge_requests/337- Settings on D7:
-- Setdrupalorg_token
to the same value as the one set in D10
-- Setup queuedrupalorg_issue_events
- Settings on D10:
-- Allow 'contribution_records' indrupalorg_allowed_content_types
-- Allow/contribution-record*
paths on Fastly
-- Setup environment variable so this line works:$config['drupalorg.settings']['token'] = getenv('DRUPALORG_TOKEN');
-- Setup queuecontribution_records_import_queue_worker
- 🇪🇸Spain fjgarlin
Added a configurable way to throttle the requests to the new system, in case we need it.
- 🇪🇸Spain fjgarlin
The second MR https://git.drupalcode.org/project/drupalorg/-/merge_requests/337 is mostly ready, but it relies on MR336 being merged first together with the deployment steps for that part.
After that, and when this is merged, we should be able to switch back and forth between the "legacy" and "modern" credit system with the following commands:
Use modern system:
drush vset drupalorg_credit_system 'modern' drush cc views
Switch back to legacy system:
drush vset drupalorg_credit_system 'legacy' drush cc views
A third part, and once the new system is stable and in use, will be to clean up the code from the legacy system and remove the switch, but we will go one step at a time.
- Status changed to Needs review
22 days ago 11:23am 15 May 2025 - 🇪🇸Spain fjgarlin
Updated the IS as we updated some of the token and headers names on both D7 and D10.
- First commit to issue fork.
-
drumm →
committed 8439c6b4 on 7.x-3.x authored by
fjgarlin →
Issue #3327584 by fjgarlin: Send issue credit information to D10 site
-
drumm →
committed 8439c6b4 on 7.x-3.x authored by
fjgarlin →
- 🇪🇸Spain fjgarlin
SA nodes can now be sent to the new site to create the corresponding Contribution Credit.
MR: https://git.drupalcode.org/project/drupalorg/-/merge_requests/350/diffs
Once deployed:
-drush drupalorg-contribution-records-sync --node-type=sa --raw-import=2
-drush queue-run drupalorg_issue_events
(This might not be needed as it is the same queue as with the previous step) -
drumm →
committed 3ef00887 on 7.x-3.x authored by
fjgarlin →
Issue #3327584: Allow security advisories to be sent to contrib records...
-
drumm →
committed 3ef00887 on 7.x-3.x authored by
fjgarlin →
- Merge request !353Check issue status and always add author as credit. → (Merged) created by fjgarlin
- 🇪🇸Spain fjgarlin
After the first full import run, we've had around ~1% missing on the new site. The reason for most of these (if not all) was that the issue didn't even have a comment, not even the automated comment #1 which is always linked to the author.
We will send the author with no attribution (as none can be calculated) when there are no comments on the issue. If the author makes a comment with attribution, then this last one will be taken instead.
MR to fix this situation: https://git.drupalcode.org/project/drupalorg/-/merge_requests/353/diffs
After that, we will need to re-run some of the above commands with selected NIDs.
-
drumm →
committed 3513a3e5 on 7.x-3.x authored by
fjgarlin →
Issue #3327584: Check issue status and always add author as credit
-
drumm →
committed 3513a3e5 on 7.x-3.x authored by
fjgarlin →
- Merge request !354Force an entry in the array if no credits could be retrieved. → (Merged) created by fjgarlin
- 🇪🇸Spain fjgarlin
Edge case for when there are no contributors: https://git.drupalcode.org/project/drupalorg/-/merge_requests/354/diffs
-
drumm →
committed 5f4d224c on 7.x-3.x authored by
fjgarlin →
Issue #3327584: Set an entry in the credit array if no credits could be...
-
drumm →
committed 5f4d224c on 7.x-3.x authored by
fjgarlin →
- 🇪🇸Spain fjgarlin
More edge cases:
- Issues with no title
- Issues with no comments and the users who created them no longer have an accountMR for that: https://git.drupalcode.org/project/drupalorg/-/merge_requests/355/diffs
-
drumm →
committed 6a19a3c6 on 7.x-3.x authored by
fjgarlin →
Issue #3327584: Fix issue credit migration edge case for issues with no...
-
drumm →
committed 6a19a3c6 on 7.x-3.x authored by
fjgarlin →