PHP 8.1 compatibility

Created on 9 December 2022, almost 2 years ago
Updated 8 January 2024, 10 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

πŸ‡¨πŸ‡­Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States gmercer

    Re-rolled patch #2, and also added a couple other small changes that where I have gotten errors opening Past Settings page:
    /admin/config/development/past

  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland
    1. +++ b/modules/past_db/tests/src/Functional/PastDBTest.php
      @@ -25,6 +25,7 @@ class PastDBTest extends PastDBTestBase {
           'views_ui',
           'block',
      +    'entity_reference',
         ];
       
      

      that's actually restoring the line that had been removed.

    2. +++ b/modules/past_form/past_form.module
      @@ -51,7 +51,7 @@ function past_form_form_past_settings_alter(&$form, FormStateInterface $form_sta
      -    '#default_value' => implode("\n", $config->get('past_form_log_form_ids')),
      +    '#default_value' => implode("\n", is_array($config->get('past_form_log_form_ids')) ? $config->get('past_form_log_form_ids') : []),
           '#description' => t("A list of form_id's that will be logged. Put each on a new line. (* is supported as wildcard, for instance views_ui_*)"),
      
      +++ b/src/Form/PastSettingsForm.php
      @@ -81,7 +81,7 @@ class PastSettingsForm extends ConfigFormBase {
           foreach (RfcLogLevel::getLevels() as $key => $value) {
      -      if (in_array($key, $config->get('backtrace_include'))) {
      +      if (!empty($config->get('backtrace_include')) && in_array($key, $config->get('backtrace_include'))) {
      

      These can be done with an array case or short form ?: []. it

Production build 0.71.5 2024