- Status changed to Active
almost 2 years ago 3:11pm 19 January 2023 - @eojthebrave opened merge request.
- πΊπΈUnited States eojthebrave Minneapolis, MN
Well here's a start. I added a label() method and a basic test for it.
It looks like the isInternal() method is defined by EntityTypeInterface which the GroupRelationshipType / GroupRelationshipTypeInterface doesn't currently implement. But maybe it should? It's not immediately clear to me if that's a good idea or not. What do you think?
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Renaming the issue to reflect what's going on. As I do not intend to actually export these labels
- Status changed to Needs review
almost 2 years ago 9:55am 7 February 2023 - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Adjusted wording a bit more, using patch workflow now because it can test vs 2 versions.
- π§πͺBelgium lobsterr
kristiaanvandeneynde β credited LOBsTerr β .
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Adding credit from duplicate issue
The last submitted patch, 19: group-3324506-19-v2.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Spin-off here: π Mark GroupRelationshipType entities as internal Fixed
Forgot to change the machine name in the 2.0.x patch and also we were comparing escaped to unescaped in the test.
-
kristiaanvandeneynde β
committed a3628086 on 2.0.x
Issue #3324506 by kristiaanvandeneynde, eojthebrave, LOBsTerr: Group...
-
kristiaanvandeneynde β
committed a3628086 on 2.0.x
-
kristiaanvandeneynde β
committed 0fe0c455 on 3.0.x
Issue #3324506 by kristiaanvandeneynde, eojthebrave, LOBsTerr: Group...
-
kristiaanvandeneynde β
committed 0fe0c455 on 3.0.x
- Status changed to Fixed
almost 2 years ago 10:27am 7 February 2023 - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Fixed, will mark as internal in a follow-up as to not stall this issue any longer then necessary.
- πΊπΈUnited States eojthebrave Minneapolis, MN
β€οΈ. Thanks @kristiaanvandeneynde. I'll give this a try on my site and report back if anything is weird. Though I don't think it will be.
- πΊπΈUnited States djween
Hello, I was looking to trigger actions based off of membership related events in Business Rules using for example entity insert event with target entity type group relationship and bundle group membership or group invitation. Not even sure if it would have been possible because I couldn't test without the labels appearing but theoretically it seemed like it could work. If it would work seems like it would be a miss to prevent this capability using out of box BR and Groups for things as basic as publishing a welcome message or emailing a welcome message.
Automatically closed - issue fixed for 2 weeks with no activity.