Fix CSS and JS on translation form

Oops I honestly do not understand what is happening here, but there is an issue with the merge request #1. No commit can be seen. @TeeBeeCoder is it fixable?

Here we are @FMB. Sorry, I don't know why the commit was missing, but I pushed it back.

For instance, I styled the filter form using the style currently used on the localize website. As I said, it would be nice to use CSS modern implementation in a second time. When all the decisions will be made for UX/UI, I'll adjust it to a more modern CSS code.

Thanks @ptt-homme!

Is it just me, or the D9+ version:

still does not look exactly like the D7 version:

Also, when I click on the "Translate" icon, I get this alert box, which does not appear in the D7 version:

@FMB,

I'll check it!

@FMB,

I found a way to reproduce the alert box on the D7 version, please see attached file. I think that the behavior is the one expected, but I'm not sure about the UX.

Steps:
- go on https://localize.drupal.org/translate/languages/fr/translate?project=dru...
- click on the pen
- see the alert box

Indeed, but no alert is triggered when the field is "empty", i.e. when it contains the string "", unlike the D9 version. I guess there is something wrong with this string.

I confirm that the UI / UX differs as described in #10 + #12 + #13. Already found and fixed the #13 issue locally. Will continue soon'ish.

Great @shmy, I am looking forward to seeing what it was!

Alignment should be ok now:

How do i reproduce the .error class as mentioned in #1? I've seen how it looks on D7 (when adding the class manually) but would be nice too know how / when its set.

How do i reproduce the .error class as mentioned in #1? I've seen how it looks on D7 (when adding the class manually) but would be nice too know how / when its set.

It happens when the source string contains an argument, such as "%page" in "404 error: %page not found." and you submit a suggestion without said argument.

shmy → changed the visibility of the branch 3.0.x to hidden.

:face_palm: While working with this old code base and seeing so much copied 7.x it didn't crossed my find that there could a form validation implementation and instead i did a quick grep for any 'error' string.

Anyway i've addressed the above mentioned issues.

By the way the in the latest commit of the MR 46 i've reverted #3396437 partly but omitted the revert for the submissions.js file because its part of l10n_statistics submodule. Not sure how to handle this (re-opening the issue? new issue?).

By the way the in the latest commit of the MR 46 i've reverted #3396437 partly but omitted the revert for the submissions.js file because its part of l10n_statistics submodule. Not sure how to handle this (re-opening the issue? new issue?).

You can handle this in a new issue.

Thank you so much for your work @shmy, much appreciated!

Automatically closed - issue fixed for 2 weeks with no activity.