I just installed and testing the module and got this issue too.
I'm having this same issue and I have no such conflict with another Flag module.
Only admin can access the block (no roles restricted).
Flag Bookmark and Unflag Bookmark permissions are given to authenticated users.
Same even if I give users permission to See Other's Bookmarks just to test.- Status changed to Needs review
7 months ago 6:14pm 10 December 2023 - πΊπΈUnited States asherry
We're having the same issue. This block is doing its access check based on
\Drupal\flag\Entity\Flag::access()
. I don't know if/when things changed, but, the flag module doesn't actually seem to use the ::access() method for flagging, it seems to just use that for administration.Access to see if a user has the permission to do a flag action is done with the "access_check" tagged services FlagAccessCheck and UnFlagAccessCheck. It makes sense I guess, the actual places it needs to check access are primarily done in routes. These methods are calling the
Flag::actionAccess
method and rather than use "create" as an action, it uses "flag" and "unflag".I added a patch to check which action needs to be sent to ::actionAccess and then returned that for ::blockAcces.
- πΊπΈUnited States asherry
Fixed two major issues with the last patch.
- Before auto alias creation we need to check if the current page is 404. (this might need more work)
- Check to see if there is an existing alias in the current language, OR in language unspecified.