I just installed and testing the module and got this issue too.
I'm having this same issue and I have no such conflict with another Flag module.
Only admin can access the block (no roles restricted).
Flag Bookmark and Unflag Bookmark permissions are given to authenticated users.
Same even if I give users permission to See Other's Bookmarks just to test.- Status changed to Needs review
about 1 year ago 6:14pm 10 December 2023 - πΊπΈUnited States asherry
We're having the same issue. This block is doing its access check based on
\Drupal\flag\Entity\Flag::access()
. I don't know if/when things changed, but, the flag module doesn't actually seem to use the ::access() method for flagging, it seems to just use that for administration.Access to see if a user has the permission to do a flag action is done with the "access_check" tagged services FlagAccessCheck and UnFlagAccessCheck. It makes sense I guess, the actual places it needs to check access are primarily done in routes. These methods are calling the
Flag::actionAccess
method and rather than use "create" as an action, it uses "flag" and "unflag".I added a patch to check which action needs to be sent to ::actionAccess and then returned that for ::blockAcces.
- πΊπΈUnited States asherry
Fixed two major issues with the last patch.
- Before auto alias creation we need to check if the current page is 404. (this might need more work)
- Check to see if there is an existing alias in the current language, OR in language unspecified. - Status changed to RTBC
6 months ago 9:11pm 5 July 2024 - πΊπΈUnited States jcandan
Patch #6 fixed the issue for us on Drupal 10.3.0 with Bookmarks 1.0.2.
- Status changed to Needs work
6 months ago 1:39pm 8 July 2024 - πΊπΈUnited States jcandan
Seems I missed a bug. After applying the patch, the links and title fields don't show in the Bookmarks list table. Digging.
- Merge request !4Issue #3320230: Fix bookmark link not shown for non-admin users β (Merged) created by jcandan
- Status changed to Needs review
6 months ago 11:45pm 10 July 2024 -
jcandan β
committed fd409d46 on 1.0.x
Issue #3320230: Fix bookmark link not shown for non-admin users
-
jcandan β
committed fd409d46 on 1.0.x
- Status changed to Fixed
6 months ago 11:50pm 10 July 2024 - πΊπΈUnited States asherry
Did you actually use the patch I had? I don't see a credit associated with this issue, or maybe it was because I got a warning that says "Double check attribution"
Automatically closed - issue fixed for 2 weeks with no activity.
- π¬π§United Kingdom problue solutions Northern Ireland
Dev version dated 12 July 2024 fixes the access problem, but the issue descibed in #8 (links not appearing in bookmark list table) is not fixed.
- πΊπΈUnited States jcandan
Apologies, I should have noted this here before. The bug described in #8 and #18 should be resolved by π Fix Bookmarks view is missing a display Needs review .