Fix bookmark link not shown for non-admin users

Created on 9 November 2022, about 2 years ago
Updated 2 August 2024, 5 months ago
πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States rdworianyn

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • I just installed and testing the module and got this issue too.
    I'm having this same issue and I have no such conflict with another Flag module.
    Only admin can access the block (no roles restricted).
    Flag Bookmark and Unflag Bookmark permissions are given to authenticated users.
    Same even if I give users permission to See Other's Bookmarks just to test.

  • Status changed to Needs review about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States asherry

    We're having the same issue. This block is doing its access check based on \Drupal\flag\Entity\Flag::access(). I don't know if/when things changed, but, the flag module doesn't actually seem to use the ::access() method for flagging, it seems to just use that for administration.

    Access to see if a user has the permission to do a flag action is done with the "access_check" tagged services FlagAccessCheck and UnFlagAccessCheck. It makes sense I guess, the actual places it needs to check access are primarily done in routes. These methods are calling the Flag::actionAccess method and rather than use "create" as an action, it uses "flag" and "unflag".

    I added a patch to check which action needs to be sent to ::actionAccess and then returned that for ::blockAcces.

  • πŸ‡ΊπŸ‡ΈUnited States asherry

    Fixed two major issues with the last patch.
    - Before auto alias creation we need to check if the current page is 404. (this might need more work)
    - Check to see if there is an existing alias in the current language, OR in language unspecified.

  • Status changed to RTBC 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jcandan

    Patch #6 fixed the issue for us on Drupal 10.3.0 with Bookmarks 1.0.2.

  • Status changed to Needs work 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jcandan

    Seems I missed a bug. After applying the patch, the links and title fields don't show in the Bookmarks list table. Digging.

  • πŸ‡ΊπŸ‡ΈUnited States jcandan
  • Status changed to Needs review 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jcandan
  • Status changed to Fixed 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jcandan
  • πŸ‡ΊπŸ‡ΈUnited States asherry

    Did you actually use the patch I had? I don't see a credit associated with this issue, or maybe it was because I got a warning that says "Double check attribution"

  • πŸ‡ΊπŸ‡ΈUnited States jcandan
  • πŸ‡ΊπŸ‡ΈUnited States jcandan
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • πŸ‡¬πŸ‡§United Kingdom problue solutions Northern Ireland

    Dev version dated 12 July 2024 fixes the access problem, but the issue descibed in #8 (links not appearing in bookmark list table) is not fixed.

  • πŸ‡ΊπŸ‡ΈUnited States jcandan

    Apologies, I should have noted this here before. The bug described in #8 and #18 should be resolved by πŸ› Fix Bookmarks view is missing a display Needs review .

Production build 0.71.5 2024