- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Try this. It still needs tests but runs every calculator a 2nd time allowing them to alter the complete build. If you use the 4 "alter mode" methods correctly, you should be able to take away any permission you do not like.
You could add a calculator that doesn't add anything itself, but does alter stuff. And you can even have said calculator add cache contexts for what it's doing by specifying them in getPersistentCacheContexts().
Feedback welcome.
The last submitted patch, 3: fp-3319906-3.patch, failed testing. View results →
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
This adjusts the tests. Still needs tests to prove that alteration actually works
The last submitted patch, 5: fp-3319906-5.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Should fix fails, still needs a test for altering.
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
And this adds the extra test
-
kristiaanvandeneynde →
committed e749f72b on 1.0.x
Issue #3319906 by kristiaanvandeneynde: Make it possible to alter...
-
kristiaanvandeneynde →
committed e749f72b on 1.0.x
- Status changed to Fixed
almost 2 years ago 12:43pm 23 March 2023 - 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Marking as fixed for now so I can release Group 3.0.0 and 2.0.0.
Only modules using removeItem* or addItem with Overwrite set to TRUE will have to move a small bit of code to the new alterPermissions() part of their calculators.
Automatically closed - issue fixed for 2 weeks with no activity.