- 🇺🇸United States dww
The explanation basically makes sense, but I wouldn't want to commit this without test coverage. If you'd like to see this happen, please provide tests.
Thanks!
-Derek
After creating a widget that removes multiple groups per entity, there was an issue when postSave was executed. It will delete the first group_content_entity, which invokes GroupContent to save. Inside of a hook_update, it saves the entity thus triggering entitygroupfield::postSave again. When it is invoked this time, the group_content_entity has already been deleted but there is still a reference in the iterator.
1. Create an entity that can have multiple groups.
2. Add multiple groups to that entity.
3. Remove multiple groups from that entity.
This is a basic check to ensure the entity is still set on the group_content before attempting to access it.
Needs work
1.0
Widgets
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
The explanation basically makes sense, but I wouldn't want to commit this without test coverage. If you'd like to see this happen, please provide tests.
Thanks!
-Derek