The PHP 8.1 generates Deprecated function: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in ...
for any custom entity without "label" field.
- create entity class with drush gen content-entity
- remove label field from code
- open edit entity form
Fix code here: web/core/lib/Drupal/Core/Entity/Controller/EntityController.php:267
if ($entity = $this->doGetEntity($route_match, $_entity)) {
return $this->t('Edit %label', ['%label' => $entity->label()]);
}
to
if ($entity = $this->doGetEntity($route_match, $_entity)) {
return $this->t('Edit %label', ['%label' => $entity->label() ?? '']);
}
Needs work
9.5
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I agree with @joachim, if empty we should return "Edit" and not "Edit " (extra space).
This needs tests.
Here's a re-rolled patch (11.1.x.)
Still needs tests, the remark in #11 seems to be fixed.