Drupal 9 compatability

Created on 1 November 2022, over 2 years ago
Updated 20 March 2023, about 2 years ago

Problem/Motivation

Not compatible with 9.x core

Add core_version_requirement: ^8 || ^9 to designate that the extension is compatible with Drupal 9 to xero_sync.info.yml

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine riabovol

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡¦Ukraine SmovS Lutsk
  • Issue was unassigned.
  • πŸ‡ΊπŸ‡¦Ukraine SmovS Lutsk

    Hi @jonathanshaw
    Currently, The QueuingProcessingTest and AdvancedQueuingProcessingTest are skipped in tests. These ones need deep refactoring and should be mocking the ItemManager in the way that other tests are, not mocking the Xero client. Also, I didn't find a solution for the last usage (at(0) in the expectUpdateItemEventDispatched() function). I tried to use once(), and any() with code refactoring but I noticed that the dispatch method is called differently in various tests and the test has failures with once() or any() instead of at(0). Probably this function should be split for various tests. The deprecated method at() will be removed in PHPUnit 10, but it is working in PHPUnit 9.

  • Status changed to Fixed about 2 years ago
  • πŸ‡¬πŸ‡§United Kingdom jonathanshaw Stroud, UK

    Thanks @smovs, merged!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024