From our testing, the use of drupal_static provides similar, or possibly slightly better, page load times than using static for the storage of the s3 object and config variable in the _33_get_amazons3_client function.
As well, it was noticed the $static_config variable was set outside of the conditional for rebuilding the config rather than inside it. This would mean static variable is reset every time the function is called, which is unnecessary unless there has been a change.
The attached patch includes these two adjustments. Posting for review in case anyone would like to comment, although these updates make the code in closer alignment to how it is structured in 8.x-3.x.
Closed: outdated
3.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Drupal 7 end-of-life triage:
Drupal 7 reached end of life on January 5th.
The 7.x branches of S3FS do not have any additional planned releases.
The requests in this issue do not appear to exist in the 8.x-3.x and newer branches.