PHP 8.0: Exposed filter group 'value' approach is now a bug.

Problem/Motivation

Though #2429331: Exposed filter bug: bad identifier → attempts to address a different issue, it perfectly describes the bug:

Workbench_access_handler_filter_access actively trying to work against Views handler system by providing an option named 'access_id' instead of the 'value' element that is hardcoded in a bunch of place in views_handler_filter.

Up until we had PHP 8.0 this worked more or less ok - Views would attempt to look up $row['value']'s children, and PHP would simply yield a warning message when a call to element_children($row['value']) would try to count NULL value (since $row['value'] is not even set).

With PHP 8.0 this now throws TypeError, making it impossible to configure the exposed form. See Changelog section on PHP: count - Manual.

Steps to reproduce

• Have you site running on at least PHP 8.0,
• Create a view, add exposed Workbench Access filter to it, and attempt to configure filter type - single or grouped,
• The view will throw an Ajax error.
• Switching back to PHP 7.x - exposed filter config form should work as expected.

Proposed resolution

Chang back to use the standard 'value' name.

Maybe it makes sense to reopen #2429331: Exposed filter bug: bad identifier → and provide a better upgrade path - like using hook_update_N along with checking for views provided through code and letting code maintainers know what needs to be updated?

Upgrade path

From the related ticket:

Views created with version before 7.x-1.6 will need to be resaved. Another thing to note is that this now use Views standard rendering pipeline for the 'value' element, so to get back a multiple select, the user needs to check the "Allow multiple values" checkbox.