Confusion on user picture

When I enable the module is it supposed to get rid of the options in the appearance tab that allows me to toggle user picture in posts and user picture in comments?

Yes

If so can I ask the logic behind that decision because I thought that was something that was done on a theme by theme basis.

I understand your concern here. There wasn't a perfect answer and the current code seemed like the solution available. Here is an outline of the reasons:

1. Throughout Drupal, field display is controlled by "Manage Display" settings, configured per content type (per bundle). This module is trying to remove anomalies where this isn't true.
2. The user picture setting was a big anomaly. It was set per entity type (global to all bundles), as a theme setting, for two specific entity types only (even though the idea is equally applicable to other entity types such as media). It only worked because of special custom pre-processing for each entity type.
3. The user picture used a hard-coded display mode 'compact' and this fact was not really explained in the UI. Probably Drupal allowed you to delete this view mode without a warning.

Another way of looking at it. When using "Manage Display" to control the user picture, then a theme setting can be confusing:

• Turn the theme setting on and the picture is missing - it was not enabled in manage display
• Turn the theme setting off and the picture is still there - manage display enabled a formatter that ignored the theme setting

Now documented at https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →

Automatically closed - issue fixed for 2 weeks with no activity.