s3fs_cors with private/public takeover broken by SA-CONTRIB-2022-057

Created on 5 October 2022, about 2 years ago
Updated 24 April 2023, over 1 year ago

Problem/Motivation

When using s3fs_cors with public/private takeover (see ✨ Add support for public:// and private:// takeover Fixed ), because s3fs_cors intentionall switches between the s3 and public/private file schemes, it triggers the exception added for SA-CONTRIB-2022-057.

It might be possible to fix this on the s3fs_cors side (although, not sure how), but opening this to track things.

Steps to reproduce

Proposed resolution

Potentially allow a flag to be set that allows cross-scheme operations, since this could only be set by PHP it ought to still provide the original protection.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Closed: works as designed

Version

3.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States cmlara

    While #3251424 has not yet been merged it appears to have a viable patch in it indicating this does not require changes inside of s3fs.

    As no additional requests to change this process have been submitted, combined with #2's long term integrity concerns if we were to do so I'm going to close this out as works as designed.

Production build 0.71.5 2024