- πΈπ°Slovakia poker10
Thanks for working on this.
There are 5 usages of
shmop_close()
in the code. Three inincludes/vendor/ip2location/ip2location-php/IP2Location.php
and two inincludes/geoip.inc
.Please include all these usages in the patch. I suppose we are not going to update the https://github.com/chrislim2888/IP2Location-PHP-Module in this D7 phase, so I think it will be OK to just handle the deprecations in the 3rd party library.
Also I would prefer if we use this for version comparision:
version_compare(PHP_VERSION, "8", "<")
, as this is used consistently also in D7 core.Thanks!
- @poker10 opened merge request.
- Status changed to Needs review
about 1 year ago 10:39pm 3 November 2023 - πΈπ°Slovakia poker10
Created an MR based on #2 with suggested changes, to be merged.
-
poker10 β
committed cd0c453b on 7.x-2.x
Issue #3313219 by poker10, Igumnov_aleksey: Deprecated in PHP 8.0:Call...
-
poker10 β
committed cd0c453b on 7.x-2.x
- Status changed to Fixed
about 1 year ago 10:42pm 3 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.