Explain how to use tokens immediately without going to confirmation page

Yes that's a good idea, thanks. New features need a test please. Also in 4.x it should now be called 'confirm-url-immediate', and the route name has changed.

I haven't looked into the 4.x-dev branch, but for me the merge request led to wrong hashes, so that a confirmation was impossible. The hash function in the token vs. the one in the controller mismatched.

Fix it in the initial merge request.

Here's a patch against 3.x that demonstrates the problem described in #5.

I created a new merge request against 4.x including the tests. I catched another (so far untested problem) on the ConfirmationController, when the immediate option was used: https://git.drupalcode.org/project/simplenews/-/merge_requests/33/diffs?...

Thanks.

Just wondering - is there a simpler way? [simplenews-subscriber:confirm-url]/ok

Hi,

yes, that is a simpler way and is working. Although a dedicated token acts a bit more like a reliable API for the ones using it. Let me know, what you prefer.

Thanks for fixing the bug with immediate subscription and adding a test.

There are 3 tokens that have an immediate variant - also 'subscribe-url' and 'unsubscribe-url'. I'd prefer not to add 3 more tokens, so how about instead we use the description to explain it?

'The URL of the page where subscribers can confirm their subscription changes.<strong> For immediate confirmation, put "/ok" after the token.</strong>'

The existing descriptions are outdated - please could you change them?

'The URL of the page to add a subscription.'
'The URL of the page to remove a subscription.'

I will commit the bug fix and patch in 🐛 Immediate confirmation is broken in 4.x Active thanks

I agree with you about the tokens. Then the remaining part would be just the clarification in the description, right?

Then the remaining part would be just the clarification in the description, right?

Yes I agree thanks

Here's a patch for the description change of the tokens. We could decline open merge requests for this issue then.

The existing descriptions are outdated - please could you change them?

'The URL of the page to add a subscription.'
'The URL of the page to remove a subscription.'

I hope I understood it right and changed the correct token descriptions?

Yes thanks it's good. We can add the text about /ok to the other tokens too, like this.

Automatically closed - issue fixed for 2 weeks with no activity.