Deprecated in PHP 8.0: Required parameter follows optional parameter

Thanks for working on this.

-function smart_ip_get_zip($src = NULL, &$context) {
+function smart_ip_get_zip($src, &$context) {
+  if (empty($src)){
+    $src = NULL;
+  }

There is already a fallback if the $src is empty few lines below, so I suppose we just need to remove the NULL from the parameter default value, see:

  if (empty($src)) {
    // Fallback zip file
    $src = SMART_IP_MAXMIND_LITE_CSV_DOWNLOAD_BASE_URL . '/GeoLiteCity_' . format_date(REQUEST_TIME, 'custom', 'Ym') . '01.zip';
  }

-----------

Regarding the fixes to the op_process() functions, I would say the better fix would be to just add a default value of empty string to the $field parameters, as these parameters does not seems to be used anywhere in the module or in the openlayers_proximity module anyway. And these are required now, so adding the empty string default value will only fix the deprecation, but it will not introduce and BC break.

Thanks!

Merged after applying my suggestions from #7. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.