- πΊπΈUnited States fathershawn New York
I'll open a 2.x branch since the D10 version is only CKE 5 compatible and leave the prior code in place
- Status changed to RTBC
over 1 year ago 7:21pm 19 June 2023 -
FatherShawn β
committed 8c6d849e on 2.0.x
Issue #3312842 by FatherShawn: CKEditor 5 compatibility - Working...
-
FatherShawn β
committed 8c6d849e on 2.0.x
- πΊπΈUnited States fathershawn New York
I've made a 2.0.0@beta release. Even though there is test coverage, I'd like some reports from the wild before I mark it stable.
- Status changed to Fixed
about 1 year ago 2:29pm 4 September 2023 - Status changed to RTBC
about 1 year ago 2:34pm 4 September 2023 - πΊπΈUnited States fathershawn New York
Fixed is going to automatically move to "Closed (fixed)" after a time, and I have this issue still open intentionally pending reports of success on the 2.x branch from others. See the note in the D10 section of the project page.
It works for me with CKEditor 5. I didn't migrate my settings, so I didn't test that.
However, I did encounter a couple usability issues.
- The Find/Replace dialog can't be dragged, and so there are sometimes words that are "found" but I can't see them because they are behind the dialog.
- It's annoying that I have to click "Find" before I can enter text in the "Replace" textbox or click to "Replace" or "Replace All". I don't know of a single Find/Replace implementation in any app that works like that. It's tedious and too many clicks and arbitrary restrictions.
Let me know if they need to be put in new issues.
- πΊπΈUnited States fathershawn New York
Thanks for the report. All the behaviors of the provided feature should be coming from CKEditor - I'm simply loading their package. The next step is to get a instance loaded outside of Drupal and see if it's the same interaction.
- πΊπΈUnited States fathershawn New York
Confirmed this as the default behavior. You can also download a default at the online builder.
Looks like one of my complaints already has an issue open:
- Status changed to Fixed
about 1 year ago 9:23am 27 September 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
AFAICT based on https://www.drupal.org/project/ckeditor_find/releases/2.0.0-beta1 β , this can be considered ?
Updated https://www.drupal.org/docs/core-modules-and-themes/core-modules/ckedito... β too π
- πΊπΈUnited States fathershawn New York
Sure π It's been out long enough without reports. I'll update the README and tag it stable. Thanks for the help Wim!
Automatically closed - issue fixed for 2 weeks with no activity.