Make latest version D10 Compatible

Open on Drupal.org →

Created on 24 September 2022, almost 2 years ago

Updated 23 March 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This issue is to help make this module compatible with Drupal 10.

Patches will be added to this issue that remove Drupal 10 deprecated API uses.

Remaining tasks

/src/Entity/EckEntityBundle.php:
─────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
─────────────────────────────────────────────────────────────────────────────
Check 33 Configuration entity must define a `config_export` key. See
manually https://www.drupal.org/node/2481909 →

─────────────────────────────────────────────────────────────────────────────

/src/Form/EntityBundle/EckEntityBundleDeleteConfirm.php:
────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
────────────────────────────────────────────────────────────────
Check 70 Missing explicit access check on entity query.
manually
────────────────────────────────────────────────────────────────

/src/Form/EntityType/EckEntityTypeDeleteForm.php:
────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
────────────────────────────────────────────────────────────────
Check 46 Missing explicit access check on entity query.
manually
────────────────────────────────────────────────────────────────

/tests/src/Functional/AccessTest.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 148 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 156 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Functional/ConfigImportTest.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 90 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 110 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Functional/DynamicBaseFieldTest.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 33 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 42 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 51 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 73 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Functional/EntityCRUDTest.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 27 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 76 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 101 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Functional/EntityTypeCRUDTest.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 33 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 59 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Functional/FunctionalTestBase.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 70 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 116 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 149 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Functional/LocalTaskEntityTest.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 57 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Functional/UITest.php:
──────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
──────────────────────────────────────────────────────────────────────────────
Fix with 106 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

Fix with 157 Call to deprecated method drupalPostForm() of class
rector Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.

──────────────────────────────────────────────────────────────────────────────

/tests/src/Unit/EckEntityTest.php:
─────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
─────────────────────────────────────────────────────────────────────
Check 96 Instantiation of deprecated class
manually Doctrine\Common\Annotations\SimpleAnnotationReader:
Deprecated in favour of using AnnotationReader

─────────────────────────────────────────────────────────────────────

/tests/src/Unit/PermissionsGeneratorTest.php:
─────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
─────────────────────────────────────────────────────────────────────────────
Fix now 49 Call to deprecated method assertArrayEquals() of class
Drupal\Tests\UnitTestCase. Deprecated in drupal:9.1.0 and is
removed from drupal:10.0.0. Use ::assertEquals,
::assertEqualsCanonicalizing, or ::assertSame instead.

─────────────────────────────────────────────────────────────────────────────

/eck.info.yml:
────────────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
────────────────────────────────────────────────────────────────────────────
Check 0 Value of core_version_requirement: ^8 || ^9 is not
manually compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.

────────────────────────────────────────────────────────────────────────────

📌 Task

Status

Closed: duplicate

Component

Code

Created by

🇮🇳India Adarshsri786

Live updates comments and jobs are added and updated live.

Drupal 10 compatibility

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇫🇷France benJBmC
Like @RgnYLDZ I also tested the module in dev version on D10.0.2 by simply changing the line in .info file :
core_version_requirement: ^8.8 || ^9 || ^10

Used with contrib module Inline Entity Form, no problem to report for the moment !
Comment over 1 year ago →
🇨🇦Canada _randy
I can concur on D10.0.3, patching ECK to use || 10 does indeed work at the moment.
Please commit to dev branch at the very least.
Comment over 1 year ago →
🇺🇸United States chadmandoo
Adding the core version requirement works. Can we get this in dev? Currently having to download manually.
Status changed to Closed: duplicate over 1 year ago5:04pm 23 March 2023
Comment over 1 year ago →
🇫🇷France benJBmC
@chadmandoo about that :

Adding the core version requirement works. Can we get this in dev? Currently having to download manually.

In the meantime you can avoid the composer install error and install dev version using composer with the Lenient Composer Plugin → .
Just do this before composer install :

$ composer require mglaman/composer-drupal-lenient $ composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/eck"]'
And then the magic happens :-)

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024