Contrib.social

Update datadome integration snippets to a working version

Open on Drupal.org →
Created on 13 September 2022, over 2 years ago
Updated 21 February 2024, 10 months ago

Problem/Motivation

In trying to set up integration with Datadome, we asked Fastly support to add the necessary pragmas to the integration and then uploaded/enabled the "DataDome Bot Detection integration" edgemodule snippets.

We started noticing some issues with Datadome (new cookies set on every request, etc), and have been investigating why we can't get whole page caching to work. During the investigation, we started examining the datadome snippets that are uploaded from the Fastly Drupal module.

We noticed references to Magento, like this:

set bereq.http.x-datadome-params:requestmodulename = "FastlyMagento";

I might assume that this might be a legacy issue. Perhaps the FastlyMagento module was initially only supposed to support Magento but it also works for Drupal, but they just never renamed it?

In any case, I would like more clarity on this issue and what the implications are since I'm trying to troubleshoot a broken integration. Can anyone confirm that the snippets that are part of the datadome integration edge modules, are the right ones to be using on a Drupal 9 site with Fastly?

🐛 Bug report
Status

Needs work

Version

4.0

Component

Code

Created by

🇺🇸United States apotek

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States apotek

    Just refreshed this patch/branch from origin. I see also that we have a new branch for Drupal 9 compatibility. I can create a second issue in that branch with this change-set, or I could rebase these changes to the 4.x (Drupal 9 branch) and get these changes backported if this ever gets merged in. Any preferences?

  • Comment over 1 year ago →
    🇺🇸United States apotek

    > Could I ask you to kindly change the module name from FastlySnippet to FastlyDrupal

    Hi Laure, I have done as you requested. If you think the changes look good, please mark this issue "reviewed".

  • @ldegri opened merge request.
  • Comment over 1 year ago →
    System Message
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇫🇷France ldegri
  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇭🇷Croatia xSDx

    @apokek I see that code in MR !12 has many code changes that are not related to related Datadome integration.
    Many things are already on 4.0.x-dev branch that should be there since that branch is for D9/10 and here we have a mix.
    This MR should contain code only regarding datadome integration and be against 4.0.x-dev branch and then backport it to 8.3.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024